Skip to content

release: 4.2.0 #5014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 22, 2022
Merged

release: 4.2.0 #5014

merged 3 commits into from
Mar 22, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Mar 22, 2022 •
edited
Loading

This PR is to generate a new release of code-server at v4.2.0

Screenshot

image

TODOs

Follow "Publishing a release" steps in ci/README.md

  • publish release and merge PR
  • update the AUR package

Fixes #4942

@jsjoeio jsjoeio self-assigned this Mar 22, 2022
@jsjoeio jsjoeio requested a review from a team March 22, 2022 21:08
@github-actions
Copy link

github-actions bot commented Mar 22, 2022 •
edited
Loading

✨ code-server docs for PR #5014 is ready! It will be updated on every commit.

@codecov
Copy link

codecov bot commented Mar 22, 2022 •
edited
Loading

Codecov Report

Merging #5014 (7d56da4) into main (a1af9e2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5014   +/-   ##
=======================================
  Coverage   71.30%   71.30%           
=======================================
  Files          30       30           
  Lines        1683     1683           
  Branches      373      373           
=======================================
  Hits         1200     1200           
  Misses        413      413           
  Partials       70       70

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1af9e2...7d56da4. Read the comment docs.

@jsjoeio jsjoeio temporarily deployed to npm March 22, 2022 21:13 Inactive
@jsjoeio jsjoeio marked this pull request as ready for review March 22, 2022 21:24
@jsjoeio jsjoeio temporarily deployed to npm March 22, 2022 21:30 Inactive
code-asher
code-asher approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One spot I think we need to update, otherwise looks good!

@jsjoeio jsjoeio temporarily deployed to npm March 22, 2022 22:22 Inactive
@jsjoeio jsjoeio merged commit cf7cff0 into main Mar 22, 2022
@jsjoeio jsjoeio deleted the v4.2.0 branch March 22, 2022 23:34
@jsjoeio jsjoeio restored the v4.2.0 branch March 22, 2022 23:34
@jsjoeio jsjoeio deleted the v4.2.0 branch March 22, 2022 23:34
@jsjoeio jsjoeio restored the v4.2.0 branch March 22, 2022 23:34
@benz0li
Copy link
Contributor

benz0li commented Mar 23, 2022

@jsjoeio Help > About reports code-server: vUnknown.

version

@benz0li
Copy link
Contributor

benz0li commented Mar 23, 2022 •
edited
Loading

@jsjoeio I have noticed, that the Assets for v4.2.0 are ~90 MB smaller than the ones for v4.1.0.

ℹ️ There are no source map files in v4.2.0, although being pointed to in the JS files (e.g. lib/vscode/out/vs/loader.js).

Should I open an issue regarding this?

@benz0li benz0li mentioned this pull request Mar 23, 2022
Closed
3 tasks
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Mar 23, 2022

This looks like a bug: #5014 (comment)

Do you mind opening a bug report for that? You can leave most of it blank (I know how to reproduce).

@jsjoeio I have noticed, that the Assets for v4.2.0 are ~90 MB smaller than the ones for v4.1.0.

ℹ️ There are no source map files in v4.2.0, although being pointed to in the JS files (e.g. lib/vscode/out/vs/loader.js).

Should I open an issue regarding this?

Great question! I'm not sure if that was intentional 🤔 Could have missed a patch potentially. Any ideas @code-asher ?

@jsjoeio jsjoeio deleted the v4.2.0 branch March 23, 2022 22:40
@code-asher
Copy link
Member

code-asher commented Mar 23, 2022 •
edited
Loading

Definitely not intentional. I bet it is due to the switch to using Code's packaging task instead of cobbling it together ourselves. They might be removing the source maps because they host them elsewhere. So we might have to patch that removal out.

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Mar 23, 2022

Ahhh gotcha. We can track here: #5026

Thanks @benz0li for reporting!

@jsjoeio jsjoeio mentioned this pull request Mar 23, 2022
Closed
3 tasks
TinLe pushed a commit to TinLe/code-server that referenced this pull request Apr 23, 2022
@jsjoeio @TinLe
release: 4.2.0 (coder#5014)
be99ea1 
* chore(release): bump version to 4.2.0

* chore: update CHANGELOG

* chore: bump helm chart version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher approved these changes

Assignees

@jsjoeio jsjoeio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

release: v4.2.0
3 participants
@jsjoeio @benz0li @code-asher